Refactor walk #986
Merged
Refactor walk #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
============================================
+ Coverage 78.51% 78.76% +0.24%
- Complexity 1866 1919 +53
============================================
Files 169 172 +3
Lines 6088 6197 +109
Branches 1153 1199 +46
============================================
+ Hits 4780 4881 +101
+ Misses 871 861 -10
- Partials 437 455 +18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #441, closes #467, closes #841, closes #868, closes #882
This contains breaking changes to those using the walk functionality
When using the walker with defaults the
defaultacross a$refare properly resolved and used.The behavior for the property listener is now more consistent whether or not validation is enabled. Previously if validation is enabled but the property is
nullthe property listener is not called while if validation is not enabled it will be called. Now the property listener will be called in both scenarios.The following are the breaking changes to those using the walk functionality. Previously there wasn't a way to get the
JsonSchemaof the schema that was referenced by theschemaNodeand it was unclear what theschemaLocationorevaluationPathwas referring to.WalkEventschemaLocationgetValidator().getSchemaLocation(). For items and properties:getSchema().getSchemaLocation()evaluationPathgetValidator().getEvaluationPath(). For items and properties:getSchema().getEvaluationPath()schemaNodegetSchema().getSchemaNode()parentSchemagetSchema().getParentSchema()schemanodeinstanceNodecurrentJsonSchemaFactorygetSchema().getValidationContext().getJsonSchemaFactory()validator